Ensure all default type params are mapped to some default even in circular scenarios #28423
+232
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
requested review from
sandersn,
DanielRosenwasser,
ahejlsberg and
a user
DanielRosenwasser
requested changes
Nov 9, 2018
|
@DanielRosenwasser this OK? |
DanielRosenwasser
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28388
In #28222 we started having type parameters have a "base default" of their constraint while we solve for their defaults - however when a type parameter is circularly constrained (we allow this) and circularly defaulted (that we allow this is what caused the last change), this caused uninstantiated parameters to leak into the default. Now we ensure that any references in the constraint to type parameters being default'ed are mapped to the base default type for the context (
{}oranydepending on JS-or-not).